fix: preflight.ps1 asset-mode helper renamed to Exit-Asset so PSScriptAnalyzer passes (#151, C)
CI / verify (push) Successful in 2m20s
CI / pwsh (push) Successful in 1m45s
Release / release (push) Successful in 34s

Files changed:
- CHANGES.md
- VERSION
- tools/preflight.ps1
This commit is contained in:
torben committed 2026-10-01 13:46:51 +02:00
1 parent c33e8cdfb1
commit d6e973c3ce
3 files changed
+26 -17

No files matched your search

+12 -3
View File
@@ -59,7 +59,7 @@ concern - readable here, never shipped as something to parse.
---
## 8.0.0-beta.16 - 2026-10-01 - Preflight as a release asset: download, verify and unpack the stack, then run the tree preflight
## 8.0.0-beta.17 - 2026-10-01 - preflight.ps1: the asset-mode error helper is Exit-Asset, so PSScriptAnalyzer passes
**Author:** Torben Nehmer
@@ -125,8 +125,16 @@ concern - readable here, never shipped as something to parse.
- bug-report instruction: step 1 no longer calls every bundle unpseudonymised
- setup-instance step 15 names --no-push for a local-only first publish; gates.md and a docstring follow #159
- raw/CONTRACT.md points at the path budget for a name accepted from incoming/
- preflight.ps1: the asset-mode error helper is Exit-Asset, so PSScriptAnalyzer passes
<!-- /wikitool:bumps -->
### preflight.ps1: the asset-mode error helper is Exit-Asset, so PSScriptAnalyzer passes
The helper that ends asset mode with exit 1 was called `Stop-Asset`. `Stop` is one of the verbs
PSScriptAnalyzer reads as changing system state, so `PSUseShouldProcessForStateChangingFunctions`
failed the CI `pwsh` job on the previous bump. It is now `Exit-Asset`, beside `Exit-WithGuide`;
behaviour is unchanged.
### Preflight as a release asset: download, verify and unpack the stack, then run the tree preflight
Section C of #151, the first install. Until now a new user had to get the stack onto the machine
@@ -148,8 +156,9 @@ script with empty placeholders and no `--archive` exits 1 saying it does not com
for a machine that cannot download, and is the entry point the tests use.
On POSIX asset mode needs `curl`, `tar` and `sha256sum` (or `shasum`) and stops with exit 42 and
the usual guidance block when one is missing; the PowerShell script uses what Windows ships plus
`tar`. On Windows with long paths off, the 95-character folder limit is judged at the final
the usual guidance block when one is missing; the PowerShell script uses what Windows 10 and 11
ship (`Invoke-WebRequest`, `Get-FileHash`, `tar.exe`) and stops the same way only when `tar` is
gone. On Windows with long paths off, the 95-character folder limit is judged at the final
target before anything is unpacked, so a too-long `--into` stops with exit 42 and the fix is a
shorter folder. Git Bash gets the target and archive converted with `cygpath -u`, because GNU
tar would read `C:` as a host.