fix: preflight.ps1 asset-mode helper renamed to Exit-Asset so PSScriptAnalyzer passes (#151, C)

Files changed:
- CHANGES.md
- VERSION
- tools/preflight.ps1

tools/preflight.ps1

@@ -221,7 +221,7 @@ function Test-LongPathsEnabled {
     }
 }
 
-function Stop-Asset {
+function Exit-Asset {
     param([string]$Message)
     Write-ErrorLine "preflight: $Message"
     exit 1
@@ -238,19 +238,19 @@ function Resolve-AssetPath {
 function Invoke-AssetMode {
     $target = if ($Into) { Resolve-AssetPath $Into } else { Join-Path $Dir 'chemenu' }
     if ($null -ne (Get-Item -LiteralPath $target -Force -ErrorAction SilentlyContinue)) {
-        Stop-Asset "$target already exists - nothing was unpacked. Choose another folder with --into <path>, or move the existing one away."
+        Exit-Asset "$target already exists - nothing was unpacked. Choose another folder with --into <path>, or move the existing one away."
     }
 
     if (-not $Archive -and (-not $ReleaseArchiveUrl -or -not $ReleaseChecksumUrl)) {
-        Stop-Asset 'this copy of the script does not come from a release (it has no download address). Download preflight.ps1 from the release page, or pass --archive <tarball>.'
+        Exit-Asset 'this copy of the script does not come from a release (it has no download address). Download preflight.ps1 from the release page, or pass --archive <tarball>.'
     }
     if ($Archive) {
         $Archive = Resolve-AssetPath $Archive
         if (-not (Test-Path -LiteralPath $Archive -PathType Leaf)) {
-            Stop-Asset "--archive: $Archive is not a file."
+            Exit-Asset "--archive: $Archive is not a file."
         }
         if (-not (Test-Path -LiteralPath "$Archive.sha256" -PathType Leaf)) {
-            Stop-Asset "--archive: $Archive.sha256 is missing - the checksum file has to lie next to the tarball."
+            Exit-Asset "--archive: $Archive.sha256 is missing - the checksum file has to lie next to the tarball."
         }
     }
 
@@ -278,7 +278,7 @@ function Invoke-AssetMode {
                 try {
                     Invoke-WebRequest -Uri $pair[0] -OutFile $pair[1]
                 } catch {
-                    Stop-Asset "the download failed: $($pair[0]) ($($_.Exception.Message)) - check the internet connection, then run this again."
+                    Exit-Asset "the download failed: $($pair[0]) ($($_.Exception.Message)) - check the internet connection, then run this again."
                 }
             }
         }
@@ -286,18 +286,18 @@ function Invoke-AssetMode {
         $first = Get-Content -LiteralPath $checksumPath -TotalCount 1 -Encoding utf8
         $match = [regex]::Match("$first", '^([0-9A-Fa-f]{64})')
         if (-not $match.Success) {
-            Stop-Asset 'the checksum file holds no sha256 in its first line - nothing was unpacked.'
+            Exit-Asset 'the checksum file holds no sha256 in its first line - nothing was unpacked.'
         }
         $want = $match.Groups[1].Value.ToLowerInvariant()
         $have = (Get-FileHash -LiteralPath $archivePath -Algorithm SHA256).Hash.ToLowerInvariant()
         if ($want -ne $have) {
-            Stop-Asset "the sha256 of the archive does not match its checksum file (expected $want, got $have) - nothing was unpacked. Delete the download and run this again."
+            Exit-Asset "the sha256 of the archive does not match its checksum file (expected $want, got $have) - nothing was unpacked. Delete the download and run this again."
         }
         Write-Line 'sha256 OK'
 
         $listing = Invoke-Native $tar.Source @('-tzf', $archivePath)
         if ($null -eq $listing) {
-            Stop-Asset 'the archive could not be read - nothing was unpacked.'
+            Exit-Asset 'the archive could not be read - nothing was unpacked.'
         }
         $tops = @(
             $listing -split "`n" |
@@ -306,13 +306,13 @@ function Invoke-AssetMode {
                 Select-Object -Unique
         )
         if ($tops.Count -ne 1) {
-            Stop-Asset 'the archive does not hold exactly one top-level folder - nothing was unpacked.'
+            Exit-Asset 'the archive does not hold exactly one top-level folder - nothing was unpacked.'
         }
         $top = $tops[0]
 
         $manifestText = Invoke-Native $tar.Source @('-xOzf', $archivePath, "$top/tools/prerequisites.txt")
         if ($null -eq $manifestText) {
-            Stop-Asset "the archive holds no $top/tools/prerequisites.txt - nothing was unpacked."
+            Exit-Asset "the archive holds no $top/tools/prerequisites.txt - nothing was unpacked."
         }
         $limit = 0
         foreach ($line in ($manifestText -split "`n")) {
@@ -338,7 +338,7 @@ function Invoke-AssetMode {
         $null = New-Item -ItemType Directory -Path $unpack
         $null = Invoke-NativeVerbose $tar.Source @('-xzf', $archivePath, '-C', $unpack)
         if (-not (Test-Path -LiteralPath (Join-Path $unpack $top) -PathType Container)) {
-            Stop-Asset "unpacking failed - the target was not created."
+            Exit-Asset "unpacking failed - the target was not created."
         }
         Move-Item -LiteralPath (Join-Path $unpack $top) -Destination $target
     } finally {
@@ -351,7 +351,7 @@ function Invoke-AssetMode {
 
     $treeScript = Join-Path $target 'tools/preflight.ps1'
     if (-not (Test-Path -LiteralPath $treeScript -PathType Leaf)) {
-        Stop-Asset 'the unpacked stack has no tools/preflight.ps1.'
+        Exit-Asset 'the unpacked stack has no tools/preflight.ps1.'
     }
     Write-Line "Unpacked into $target."
     Write-Line 'If a later step stops, run tools/preflight.ps1 from inside that folder.'